Set a sensible default for NIGHTWATCH_DEPLOY.
#293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessarcher
force-pushed
the
deploy-config-default
branch
from
2e089ba to
5a8cc67
Compare
jessarcher
force-pushed
the
deploy-config-default
branch
from
5a8cc67 to
82f3586
Compare
timacdonald
reviewed
Oct 21, 2025
| 'enabled' => env('NIGHTWATCH_ENABLED', true), | ||
| 'token' => env('NIGHTWATCH_TOKEN'), | ||
| 'deployment' => env('NIGHTWATCH_DEPLOY'), | ||
| 'deployment' => env('NIGHTWATCH_DEPLOY', rescue(static fn () => trim((string) shell_exec('git describe --tags --always 2>/dev/null')), '', false)), |
There was a problem hiding this comment.
We should look at environment variables in the first instance and only fallback to exec if there is nothing else.
- Forge:
FORGE_DEPLOY_COMMIT - Vapor?
- Cloud?
- Any other common environment variable used 3rd-party platforms? We've usually opted not to support these, but I wonder if we should.
GITHUB_SHA, for example.
If you don't have config cached, we will run this on every request. Do we care about that? I'm sure there are plenty of apps out there that don't cache config, routes, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets a sensible default for the
NIGHTWATCH_DEPLOYconfiguration option.It will attempt to get a human-friendly tag from git, and will fall back to getting a short hash.
Examples:
v1.15.2- Exact tag matchv1.15.2-1-g2451327- Changes have been committed since last tag2fd2adb- No tag availableIf
gitorshell_execis not available, it will safely fall back to an empty string.There is a performance implication from running these commands, but this is solved by config caching which should always be performed on production systems.