-
Notifications
You must be signed in to change notification settings - Fork 1.6k
KEP-3619: Graduate "Fine-grained SupplementalGroups control" To GA #5613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: everpeace The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
- [conformance tests] are added for `SupplementalGroupsPolicy` and `ContainerStatus.User` APIs | ||
|
||
[conformance tests]: https://git.k8s.io/community/contributors/devel/sig-architecture/conformance-tests.md | ||
- No negative user feedback based on production experience, promote after 2 releases in beta. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated GA criteria in two points:
- I removed "gVisor.." criteria because it is a low-level container runtime, which is not relevant to the feature. And two major CRI runtimes (containerd, CRI-O) already support this feature. I think it's enough to promote this feature to GA
- I removed conformance test criteria. IIUC, CRI runtime dependent features can't be added to the conformance test. So, I removed it.
- Removing gVisor, Kata Containers criteria because they are low-level container runtime, it's not relevant to this KEP. - Removing conformance tests criteria because we can't add this currently because this feature is Container Runtime dependent feature.
/kind documentation
/sig node
/assign @thockin @mrunalp @SergeyKanzhelev @haircommander (as the KEP reviewers)
/assign @johnbelamaric (as PRR approver)