KEP-4192: Remove obsolete fields from the API #5597
+85
−116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
stlaz
commented
Oct 1, 2025
stlaz
commented
- One-line PR description: The API described in the KEP contained several fields that were unused by the implementation. These should not appear in the Beta version of the API.
- Issue link: Move Storage Version Migrator in-tree #4192
- Other comments: There are some minor changes to the KEP structure. You may want to go commit-by-commit to see the actual changes to the API, which are isolated in a separate commit.
Signed-off-by: Stanislav Láznička <slznika@microsoft.com>
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: stlaz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
kind/kep
|
/cc @michaelasp |
michaelasp
reviewed
Oct 1, 2025
|
Overall makes sense to me, I agree we don't need the last migrated resource at all since we can just use the RV. |
- move to metav1.Conditions - remove the unused ContinueToken field - rename LastMigratedResourceNameHash to LastMigratedResource Signed-off-by: Stanislav Láznička <slznika@microsoft.com>
Signed-off-by: Stanislav Láznička <slznika@microsoft.com>
Signed-off-by: Stanislav Láznička <slznika@microsoft.com>
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.