Join Requests and Member verification #1015
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing now" This reverts commit bf3f1ff.
DRSchlaubi
reviewed
Sep 4, 2025
| val label: String?, | ||
| val choices: Optional<List<String>> = Optional.Missing(), | ||
| val values: Optional<List<String?>> = Optional.Missing(), | ||
| // FIXME This type can be String Int or Boolean, what type to put, any can't be serialized |
There was a problem hiding this comment.
You should be able to use JsonPrimitive
There was a problem hiding this comment.
Totally forgot about this, will investigate in the morning
# Conflicts: # common/api/common.klib.api # core/api/core.klib.api
|
Ready for review now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was only supposed to be join requests but apparently they're very intertwined
Done using unofficial docs for join requests and member verification
there is 1 fixme that i hope for advice on. Hopefully this is all up to scratch :)