fix(voice): ssrc user mapping #1008
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point within the last few years, Discord began to send (or always has?) initial voice Speaking events instantly after the voice Ready event. The speaking events are used to build a voice SSRC to user snowflake map, but these initial Speaking events are currently missed. This PR attempts to listen to the events ASAP in order to build the map.
For concurrency reasons, I brought in kotlinx-collections-immutable. I have a vague recollection that we wanted to do this a while ago regardless?
Preferably, the voice api gets revamped because it feels very out of control, but that's for a different issue. This PR aims to fix just this issue without changing too much API.