Fix section "2-Create Sentiment Service in e2e tutorial. #6419
+126
−135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: twoGiants The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
knative-prow-robot
added
the
needs-rebase
knative-prow
bot
added
the
size/L
The latest func cli generates a different Python function template than shown in the tutorial. There is no `setup.py` anymore and the project uses a toml file for configuration. The entire section was updated and code was corrected. Issue knative#6417. Signed-off-by: Stanislav Jakuschevskij <sjakusch@redhat.com>
twoGiants
force-pushed
the
issue-6417-fix-step-2-sentiment-service-listings
branch
from
61cd97e to
6178c95
Compare
knative-prow-robot
removed
the
needs-rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest
funccli generates a different Python function template than shown in the tutorial. There is nosetup.pyanymore and the project uses atomlfile for configuration. The entire section was updated and code was corrected. Now the function example can be build and invoked again usingfunc v0.46.0.Fixes #6417.
Proposed Changes
Update 2 Create Sentiment Service.
setup.py.