Skip to content

Conversation

simkam
Copy link
Contributor

@simkam simkam commented Oct 3, 2025

  • fixed auth indentation in examples
  • fixed wrong service reference in examples

@knative-prow knative-prow bot requested review from creydr and pierDipi October 3, 2025 13:06
Copy link

netlify bot commented Oct 3, 2025

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8093f67
🔍 Latest deploy log https://app.netlify.com/projects/knative/deploys/68dfca3c4f8a8a00081c812c
😎 Deploy Preview https://deploy-preview-6418--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

knative-prow bot commented Oct 3, 2025

Welcome @simkam! It looks like this is your first PR to knative/docs 🎉

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 3, 2025
@dprotaso
Copy link
Member

dprotaso commented Oct 6, 2025

/lgtm
/approve
/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. labels Oct 6, 2025
Copy link

knative-prow bot commented Oct 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, simkam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2025
@dprotaso
Copy link
Member

dprotaso commented Oct 6, 2025

/cherry-pick release-1.19

@knative-prow-robot
Copy link
Contributor

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.19 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot merged commit c5855ae into knative:main Oct 6, 2025
6 checks passed
@knative-prow-robot
Copy link
Contributor

@dprotaso: new pull request created: #6421

In response to this:

/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants