-
Notifications
You must be signed in to change notification settings - Fork 129
Feat/merge pdfs #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Ericbutler1209
wants to merge
19
commits into
king04aman:main
Choose a base branch
from
Ericbutler1209:feat/merge-pdfs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat/merge pdfs #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs/minutes/seconds)
…-clipboard support
…rve original helpers
👋 @Ericbutler1209 👋 We're delighted to have your pull request! Please take a moment to check our contributing guidelines and ensure you've filled out the PR template for a smooth process. We will review it soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit SHA: d2f45a8
Commit Message: Merge PDFs: add CLI for merging/inserting PDFs with validation; preserve original helpers
Description & Annotation:
This commit extended the Merge PDFs project by:
Adding a CLI to merge any number of PDFs in one command
Supporting insertion of a PDF at a chosen index
Validating file existence and type
Preserving the original helper functions for backward compatibility
This contribution matters because it makes the project scalable and flexible. Instead of merging hardcoded test files, users can now merge their own PDFs safely and reliably. It highlights my ability to modernize legacy code while maintaining backward compatibility.