stpcloud.js.org #10212
Closed
stpcloud.js.org #10212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattIPv4
requested changes
Oct 5, 2025
There was a problem hiding this comment.
👋 Hi! You need to fill out the PR description template that was provided to you when you created your PR, as we need the information it requests to process your subdomain request. If you need to reference the template again, it can be found at https://raw.githubusercontent.com/js-org/js.org/refs/heads/master/PULL_REQUEST_TEMPLATE.md -- the description of your PR must match the format in the template exactly, with you providing the information that it requests.
cnames_active.js
Outdated
| "storelocator": "storelocatorjs.github.io", | ||
| "storybook": "apex-loadbalancer.netlify.app", // noCF | ||
| "storybooks": "storybooks.github.io", | ||
| "stpcloud": "stoeaves.github.io/StpCloud" |
There was a problem hiding this comment.
As the CI error notes, you're missing a comma at the end of the line
Suggested change
| "stpcloud": "stoeaves.github.io/StpCloud" | |
| "stpcloud": "stoeaves.github.io/StpCloud", |
MattIPv4
added
invalid
missing information
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.