Use strings.Builder to form rich text string
#194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than creating a new immutable string per additional element, this reuses and grows an internal buffer.
wolveix
reviewed
Oct 1, 2025
| } | ||
|
|
||
| func (b BasicBlock) GetRichTextString() string { | ||
| return "No rich text of a basic block." |
There was a problem hiding this comment.
Any reason this text was removed?
There was a problem hiding this comment.
This was to avoid surprises and misleading messages, mainly:
- I don't think one should get a string that is not a part of a wiki page when decoding the various blocks.
- The text as-is really is trying to say "you didn't override this method in the struct that has a anonymous BasicBlock struct inside of it", but is misleading.
I should have commented more on this when I opened the PR - sorry about that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than creating a new immutable string per additional element, this reuses and grows an internal buffer.