Skip to content

Conversation

patil-pratik-87
Copy link

⏺ 📋 Summary of All Changes Made for #255

  1. Fixed LinkedIn Page Structure Issue
  • Problem: XPath //span[@dir="ltr"] returned 0 elements (page structure changed)
  • Fix: Updated to //div[contains(@Class, "artdeco-entity-lockup")] which finds actual employee elements
  1. Added URL-Based Keyword Filtering
  • Added: employee_search_keywords parameter to Company constructor
  • Implementation: Uses LinkedIn's native search via URL: /people/?keywords={encoded_keywords}
  • Benefits: Server-side filtering, more accurate than client-side parsing
  1. Added Timeout Configuration
  • Added: timeout parameter (default: 10 seconds) to Company constructor
  • Updated: All WebDriverWait calls to use self.timeout instead of hardcoded values
  • Benefit: Configurable wait times for different network conditions
  1. Added Input Validation
  • Added: Error checking for invalid parameter combinations
  • Rule: Raises ValueError if employee_search_keywords provided but get_employees=False
image image

  FIXES:
  - Updated XPath selector for employee elements to match current LinkedIn page structure

  NEW FEATURES:
  - Add employee_search_keywords parameter for URL-based filtering
  - Add configurable timeout parameter (default: 10s)
  - Implement LinkedIn native search via /people/?keywords={encoded} URLs
@case0074
Copy link

@patil-pratik-87 I am currently still unable to obtain employees using the changes you made. Please get back to me asap so I can continue building onto the project!

@case0074
Copy link

Realized it was all user error. I can scrape company employees with your changes now.

@imsaravana369
Copy link

Yeah please merge this

@patil-pratik-87
Copy link
Author

patil-pratik-87 commented Aug 13, 2025

@joeyism, can you please merge this? I don't have the privileges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants