StringBuffer -> StringBuilder and other modernizations #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent. Efficiency is important because of the work required by this algorithm. - Added maven.compiler.source/target = 1.8 since that's the earliest still-maintained version of Java. - Added Maven enforcer plugin to be sure we are building with the latest defaults for Maven. - Upgraded Junit from 3.8.1 to 4.13.1 (the latest). - Added Changelog file
bobaikato
approved these changes
Aug 13, 2021
|
I ended up using Password4j which is frequently maintained. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for adding a Maven project to https://github.com/djmdjm/jBCrypt
BCrypt needs to be efficient because it relies on "work" for security. If someone else can make a faster version, they can break your encryption more cheaply than you can make it. StringBuilder is a more efficient replacement for StringBuffer, so I wanted to make that change.
Using supported software is considered more secure than unsupported, so I moved us up to Java 8.
Added the Maven Enforcer plugin to make checking versions easier in the future.
Upgraded to the latest JUnit.
Added
CHANGELOG.mdand.gitignorefiles.Basically I wanted to update things as securely as possible while changing as little as possible. What do you think?