Skip to content

Conversation

Shadowghost
Copy link
Contributor

@Shadowghost Shadowghost commented Sep 23, 2025

Changes
After http://github.com/jellyfin/jellyfin/pull/12615 sub-ratings need to be set for proper control if the current user's ratings support them.

Issues
Fixes jellyfin/jellyfin#14838

@Shadowghost Shadowghost requested a review from a team as a code owner September 23, 2025 12:30
@jellyfin-bot
Copy link
Collaborator

jellyfin-bot commented Sep 23, 2025

Cloudflare Pages deployment

Latest commit 3a95e75
Status ✅ Deployed!
Preview URL https://ab02904f.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs

@LovesTha
Copy link

LovesTha commented Sep 23, 2025

Preview server doesn't retain setting of PG, switches to no selection (and other clients fail to load with that user when in this state) (server running 10.11.0 rc5)

@crobibero
Copy link
Member

This PR doesn't work.

parentalRating is set to the select HtmlElement.
The option value is also set to [object Object] which I don't think will work even if we extracted the selected option.

image

@Shadowghost
Copy link
Contributor Author

@crobibero @LovesTha should work now. But I'm not that well-versed in React, so code-wise this can for sure be solved better.

Copy link

@LovesTha
Copy link

That appears to work to me.

@LovesTha
Copy link

But a test in another 'problem' rating system would be sane.

@thornbill thornbill merged commit 713bb55 into jellyfin:master Sep 27, 2025
16 checks passed
@thornbill thornbill added this to the v10.11.0 milestone Sep 27, 2025
@thornbill thornbill added the enhancement Improve existing functionality or small fixes label Sep 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality or small fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Australian Classifications still lumped under 15 in 10.11.0rc5
5 participants