exp: add a retry when removing temporary refs to avoid FileLocked errors #10840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skshetry
force-pushed
the
10673-retry-remove-ref
branch
from
d1b2573 to
697472c
Compare
We have per-ref rwlocks set. But they do not prevent conflicts when refs are stored in packed-refs, as multiple processes could be modifying the same file simultaneously. On #10673, this is triggering `FileLocked` errors. Wrap ref removal in a retry loop (10 attempts, 0.1s delay) to mitigate these race conditions.
skshetry
force-pushed
the
10673-retry-remove-ref
branch
from
697472c to
e8424fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have per-ref rwlocks set. But they do not prevent conflicts when refs are stored in packed-refs, as multiple processes could be modifying the same file simultaneously.
On #10673, this is triggering
FileLockederrors.Wrap ref removal in a retry loop (10 attempts, 0.1s delay) to mitigate these race conditions.