Fix KeyboardInterrupt on Windows by manually resetting interrupt event #1434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ptosco can you confirm my understanding that this is safe and right to do regardless of the parent process behavior (i.e. without the jupyter-client PR)? |
minrk
changed the title
|
@minrk Let me double-check that; I’ll get back to you by tomorrow. Thanks. |
|
@minrk I can confirm this is safe regardless of the parent process behavior (i.e. without the jupyter-client PR). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually reset interrupt event at the receiver end rather than relying on auto reset. This makes it possible for other waiting receivers to be signaled.
In particular, C Python modules running on Windows on a Jupyter Kernel can be interrupted via "Interrupt kernel" without requiring to send the "Interrupt kernel" signal twice as currently happens (see more detailed description in the sister PR #1073 on the
jupyter_clientrepo).