Skip to content

fix the type of unit parameter of the methods that quarterOfYear plugin extends #2814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix the type of unit parameter of the methods that quarterOfYear plugin extends #2814

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions types/plugin/quarterOfYear.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,18 +9,18 @@ declare module 'dayjs' {

quarter(quarter: number): Dayjs

add(value: number, unit: QUnitType): Dayjs
add(value: number, unit: QUnitType | OpUnitType): Dayjs

subtract(value: number, unit: QUnitType): Dayjs
subtract(value: number, unit: QUnitType | OpUnitType): Dayjs

startOf(unit: QUnitType | OpUnitType): Dayjs

endOf(unit: QUnitType | OpUnitType): Dayjs

isSame(date?: ConfigType, unit?: QUnitType): boolean
isSame(date?: ConfigType, unit?: QUnitType | OpUnitType): boolean

isBefore(date?: ConfigType, unit?: QUnitType): boolean
isBefore(date?: ConfigType, unit?: QUnitType | OpUnitType): boolean

isAfter(date?: ConfigType, unit?: QUnitType): boolean
isAfter(date?: ConfigType, unit?: QUnitType | OpUnitType): boolean
}
}