Fixes issue where canvas is blocking mouse events #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR ensures the guide canvas no longer intercepts mouse events by setting pointer-events: none on its <canvas> elements.
- Added
pointerEvents = "none"to canvas styling in both guideline modules. - Aligned canvas reset logic to include pointer-events disabling.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/guidelines.js | Added pointerEvents = "none" in two canvas style blocks to stop event blocking. |
| cytoscape-grid-guide.js | Added pointerEvents = "none" in two canvas style blocks to stop event blocking. |
Comments suppressed due to low confidence (2)
cytoscape-grid-guide.js:1825
- Since the canvas now ignores pointer events, consider adding a test or integration scenario to verify underlying elements receive mouse interactions as intended.
$canvas.style.pointerEvents = "none";
cytoscape-grid-guide.js:1825
- [nitpick] Indentation here uses spaces but surrounding lines use tabs; please align with the existing indentation style for consistency.
$canvas.style.pointerEvents = "none";
| $canvas.style.top = 0; | ||
| $canvas.style.left = 0; | ||
| $canvas.style.zIndex = options.guidelinesStackOrder; | ||
| $canvas.style.pointerEvents = "none"; |
There was a problem hiding this comment.
[nitpick] The canvas style assignments are duplicated across multiple blocks; consider extracting common style logic (including pointer-events) into a helper or reusing resetCanvas to reduce repetition.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #58