feat: add bulk processing support for data protector #525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeddikBellamine
changed the title
- Add createBulkOrder utility function for creating bulk dataset orders - Add allowBulk parameter to GrantAccessParams - Add bulk order creation flow in grantAccess function - Add CREATE_BULK_ORDER and PUBLISH_BULK_ORDER status types
- Add processBulkRequest function for processing multiple protected data orders - Implement while loop to match orders until volume is reached - Support waiting for workerpool orders when none are available - Add processBulkRequest method to IExecDataProtectorCore class - Return deals, transaction hashes, and signed request orders
- Add ProcessBulkRequestStatuses, ProcessBulkRequestParams, ProcessBulkRequestResponse types - Add allowBulk parameter to GrantAccessParams - Add bulkOnly filter to GetGrantedAccessParams - Update GrantAccessStatuses with bulk order statuses
- Add comprehensive unit tests for processBulkRequest function - Test input validation for all parameters - Test error scenarios (no app orders, whitelist validation, voucher errors) - Add mock bulk orders array for consistent testing - Remove tests that cause infinite loops in unit test environment
- Update package.json and package-lock.json dependencies - Update getGrantedAccess to support bulkOnly filter - Update test configurations for bulk processing support - Update e2e tests for grantAccess and getGrantedAccess
- Remove pricePerAccess and volume parameters from createBulkOrder call in grantAccess - Keep createBulkOrder function simple with infinite volume and zero price - Fix TypeScript compilation error
- Fix TypeScript error in processBulkRequest unit tests - Update mock to return Record<number, string> instead of string - Add proper Jest typing for pushRequesterSecret mock function
- Apply Prettier formatting to Jest mock function - Break long mock function call into multiple lines for better readability
PierreJeanjacquot
force-pushed
the
feat/add-bulk-processing-support
branch
from
2ded68e to
61a1318
Compare
PierreJeanjacquot
force-pushed
the
feat/add-bulk-processing-support
branch
from
9c1b9d5 to
929cc36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces comprehensive bulk processing capabilities for the DataProtector SDK, enabling efficient processing of multiple protected data orders simultaneously.
Key Features Added:
Technical Implementation:
The bulk processing system uses a sophisticated approach where a single request order represents the entire bulk operation, while multiple deals are created by matching with different workerpool orders until the target volume is achieved.