Skip to content

Conversation

gfournieriExec
Copy link
Contributor

No description provided.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the missing ADMIN_PRIVATE_KEY environment variable to GitHub Actions workflow files to ensure script execution has access to required private keys.

  • Added ADMIN_PRIVATE_KEY environment variable to the "Set callback gas" workflow
  • Added ADMIN_PRIVATE_KEY environment variable to both deployment steps in the deploy workflow

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/set-callback-gas.yml Added ADMIN_PRIVATE_KEY environment variable to the callback gas setting step
.github/workflows/deploy.yml Added ADMIN_PRIVATE_KEY environment variable to both contract deployment and config update steps

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.82%. Comparing base (f7c634b) to head (1146f62).
⚠️ Report is 24 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #282      +/-   ##
==========================================
+ Coverage   83.66%   84.82%   +1.16%     
==========================================
  Files          38       37       -1     
  Lines        1218     1239      +21     
  Branches      227      235       +8     
==========================================
+ Hits         1019     1051      +32     
+ Misses        199      188      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment on lines 56 to +57
DEPLOYER_PRIVATE_KEY: ${{ secrets.DEPLOYER_PRIVATE_KEY }}
ADMIN_PRIVATE_KEY: ${{ secrets.ADMIN_PRIVATE_KEY }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
DEPLOYER_PRIVATE_KEY: ${{ secrets.DEPLOYER_PRIVATE_KEY }}
ADMIN_PRIVATE_KEY: ${{ secrets.ADMIN_PRIVATE_KEY }}
// Note: it is required to define both private key env variables when calling Hardhat.
DEPLOYER_PRIVATE_KEY: ${{ secrets.DEPLOYER_PRIVATE_KEY }}
ADMIN_PRIVATE_KEY: ${{ secrets.ADMIN_PRIVATE_KEY }}

@gfournieriExec gfournieriExec merged commit 9b06da2 into main Oct 13, 2025
4 checks passed
@gfournieriExec gfournieriExec deleted the fix/gha-with-pvk branch October 13, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants