-
Notifications
You must be signed in to change notification settings - Fork 14
feat: Add missing pvk to script workflows #282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds the missing ADMIN_PRIVATE_KEY environment variable to GitHub Actions workflow files to ensure script execution has access to required private keys.
- Added ADMIN_PRIVATE_KEY environment variable to the "Set callback gas" workflow
- Added ADMIN_PRIVATE_KEY environment variable to both deployment steps in the deploy workflow
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
.github/workflows/set-callback-gas.yml | Added ADMIN_PRIVATE_KEY environment variable to the callback gas setting step |
.github/workflows/deploy.yml | Added ADMIN_PRIVATE_KEY environment variable to both contract deployment and config update steps |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #282 +/- ##
==========================================
+ Coverage 83.66% 84.82% +1.16%
==========================================
Files 38 37 -1
Lines 1218 1239 +21
Branches 227 235 +8
==========================================
+ Hits 1019 1051 +32
+ Misses 199 188 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DEPLOYER_PRIVATE_KEY: ${{ secrets.DEPLOYER_PRIVATE_KEY }} | ||
ADMIN_PRIVATE_KEY: ${{ secrets.ADMIN_PRIVATE_KEY }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DEPLOYER_PRIVATE_KEY: ${{ secrets.DEPLOYER_PRIVATE_KEY }} | |
ADMIN_PRIVATE_KEY: ${{ secrets.ADMIN_PRIVATE_KEY }} | |
// Note: it is required to define both private key env variables when calling Hardhat. | |
DEPLOYER_PRIVATE_KEY: ${{ secrets.DEPLOYER_PRIVATE_KEY }} | |
ADMIN_PRIVATE_KEY: ${{ secrets.ADMIN_PRIVATE_KEY }} |
No description provided.