Safety procaution features #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francis Rossi <francisdrossi@gmail.com> Change-Id: I6a6a6964d858258374e189cde70aba8921c5e1e9
|
Hey mate! Thanks so much for the contribution! Yeah you're right control-c shouldn't kill a job / should at least warn. I'll review this soon. I think my CI is broken/clippy not installing correctly which is why the tests are failing, I'll have a look at that too (this is quite a new project sorry!) |
|
No worries! I think this project is pretty neat and beats using a watch command with squeue. I have a couple other (smallish) QOL ideas to add if you don't mind me poking around once I get some free time after work |
Signed-off-by: Francis Rossi <francisdrossi@gmail.com> Change-Id: I6a6a6964d27f7671f7292019df377bb35213a461
Signed-off-by: Francis Rossi <francisdrossi@gmail.com> Change-Id: I6a6a6964df7e5acf8b92097bfb334226d61463d0
prey169
force-pushed
the
safety_procaution_features
branch
from
0faa6b1 to
061f123
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey - I noticed Ctrl-c killed jobs, and that killing without any confirmation was pretty dangerous. Lmk if you want any edits to these and I can update if need be. Thx.