Skip to content

Conversation

g-tom
Copy link

@g-tom g-tom commented Oct 1, 2025

Documents that {alias} is resolved in Formula annotation as introduced with HHH-12280.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


* </pre>
* <p>
* The placeholder {@code {alias}} is resolved to the alias of the entity,
* e.g. in a subquery:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there should be a comma after "e.g.".

Also, as a matter of style, I prefer "for example".

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In "... of the entity, for example, in a subquery" does the "for example" still refer to the subquery or to the entity? Not being a native speaker, punctuation is not easy for me. For the sake of brevity and to avoid punctuation, maybe the example can stand for itself: 19c9698

@g-tom g-tom requested a review from gavinking October 9, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants