HHH-19812: Improvements on the Maven Enhance Plugin #11013
Conversation
…eLazyInitialization' default values and deprecate the setting Signed-off-by: Koen Aers <koen.aers@gmail.com>
…Plugins Signed-off-by: Koen Aers <koen.aers@gmail.com>
…he enablement parameters are false Signed-off-by: Koen Aers <koen.aers@gmail.com>
… using Maven Invoker Signed-off-by: Koen Aers <koen.aers@gmail.com>
|
Thanks for your pull request! This pull request appears to follow the contribution rules. › This message was automatically generated. |
…n in the User's Guide Signed-off-by: Koen Aers <koen.aers@gmail.com>
|
@yrodiere I have recreated the PR with a better structure (creating JIRA tickets for each aspect) and taking into account your remarks on the former PR. |
There was a problem hiding this comment.
Thanks! I added a few comments, but only one thing is important: the migration guide change should go to 7.0, not to 7.1 or 7.2.
Regarding #10835 (comment) , I think there was a misunderstanding: I meant that we needed a Jira issue for the backwards-incompatible change, so that it appears in the changelog and doesn't get bundled together with a simple documentation change. I didn't mean you needed a subtask for every single change :)
Anyway, it's good to have details so let's keep the many Jiras, but please don't feel like you have to go that far next time!
migration-guide.adoc
Outdated
| [[maven-plugin-changes]] | ||
| == Changes to the Maven Plugin | ||
|
|
||
| The Maven bytecode enhancement plugin has been completely rewritten since version 7.0. The change that has the | ||
| biggest consequence is that the artefactId and groupId of the Maven artefact has changed. As of now, you will | ||
| need to include the plugin in the build section in your Maven pom file as illustrated below. | ||
|
|
||
| ``` | ||
| <plugin> | ||
| <groupId>org.hibernate.orm</groupId> | ||
| <artifactId>hibernate-maven-plugin</artifactId> | ||
| <version>$currentHibernateVersion</version> | ||
| <executions> | ||
| <execution> | ||
| <goals> | ||
| <goal>enhance</goal> | ||
| </goals> | ||
| </execution> | ||
| </executions> | ||
| </plugin> | ||
| ``` | ||
|
|
||
| The documentation in the userguide has been rewritten accordingly and completed with more examples. |
There was a problem hiding this comment.
This should be merged into 7.0, not into 7.1.
There was a problem hiding this comment.
Ok, that was also my original setup. I'll remove the change.
| testLogging { | ||
| events "passed" | ||
| } |
There was a problem hiding this comment.
Does this mean we will log passing tests, but not failing ones? 🤔
There was a problem hiding this comment.
I am not sure how this slipped in... Probably something that was copied/pasted. I don't think it's needed to have these events logged anyways so I'll remove it as well. Unless you have another opinion.
… using Maven Invoker - Remove 'testLogging' during the 'integrationTest' execution Signed-off-by: Koen Aers <koen.aers@gmail.com>
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19820
https://hibernate.atlassian.net/browse/HHH-19813
https://hibernate.atlassian.net/browse/HHH-19817