Add additional step for unlocking account #5788
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomGibbon
force-pushed
the
unlock_resource_two_steps
branch
from
e4b1c79 to
c09e217
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some email clients automatically visit links inside of emails to check that the link isn't malware. This can cause the
GET resource/unlock?unlock_token=abcdeflink to be visited almost instantly for some users when theunlock_strategyis set to:emailor:both, which unlocks the user and effectively causes the lockable process to do nothing.This PR adds an
extra_stepconfig varaible, which when set to true will cause the originalGET resource/unlock?unlock_token=abcdeflink to render a new page, keeping the resource locked. This new page contains a different link (GET resource/unlock/confirm?unlock_token=abcdef), which when clicked will unlock the resource. Whenextra_stepis false, the app will behave as normal.Fixes issue: #5342