Skip to content

docs(ghcide): move most of the README in hls documentation (#3639) #4739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 15, 2025
Merged

docs(ghcide): move most of the README in hls documentation (#3639) #4739

merged 6 commits into from
Oct 15, 2025

Conversation

@blackheaven
Copy link
Contributor

No description provided.

@blackheaven blackheaven mentioned this pull request Oct 12, 2025
Closed
fendor
fendor requested changes Oct 14, 2025
View reviewed changes
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this! It is high time we update our documentation and remove outdated info.

Couple of improvements, then we can merge, imo.

blackheaven and others added 2 commits October 14, 2025 09:58
@blackheaven @fendor
Apply suggestions from code review
545636a 
Co-authored-by: fendor <fendor@users.noreply.github.com>
@blackheaven
fix: link rtd
9a6825d
@blackheaven blackheaven requested a review from fendor October 14, 2025 08:06
fendor
fendor approved these changes Oct 14, 2025
View reviewed changes
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! Just two nitpicks, then this is ready to merge :)

Do we also need to update the top-level README to contain a reference to the components page? Doesn't seem important, but perhaps for consistency.

blackheaven and others added 2 commits October 14, 2025 17:38
@blackheaven @fendor
Apply suggestions from code review
5e4e1f2 
Co-authored-by: fendor <fendor@users.noreply.github.com>
@blackheaven
fix: root README
071f347
@blackheaven
Copy link
Contributor Author

Thank you so much for you help!

I have applied your code suggestions and updated /README

@fendor fendor added the merge me Label to trigger pull request merge label Oct 14, 2025
@mergify mergify bot added the queued label Oct 15, 2025
@mergify mergify bot merged commit b7a42b9 into haskell:master Oct 15, 2025
47 of 52 checks passed
@mergify mergify bot removed the queued label Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fendor fendor fendor approved these changes

@michaelpj michaelpj Awaiting requested review from michaelpj michaelpj is a code owner

@wz1000 wz1000 Awaiting requested review from wz1000 wz1000 is a code owner

Assignees

No one assigned

Labels

merge me Label to trigger pull request merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@blackheaven @fendor