Backport of test: create all edges to leaf cleanup nodes into v1.13 #37577
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #37564 to be assessed for backporting due to the inclusion of the label 1.13-backport.
🚨
The person who merged in the original PR is:
@dsa0x
This person should resolve the merge-conflict(s) by either:
The below text is copied from the body of the original PR.
Fixes #37546
This fixes a flaky bug where the cleanup nodes in the graph may not be correctly ordered. By chance, the order is fine half of the time. The reason is because Leaf cleanup nodes were only getting attached to a single path of transitive edges, instead of all paths that led to it.
Because the bug is flaky, Executing the test multiple times like
go test ./internal/command -run TestTest_TeardownOrder -count 10
can reveal the failure before this fix.Target Release
1.13.x
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry
Overview of commits
967ea5b
77aa91a