Add patch for sqlite for config.guess to properly identify Cygwin-64 … #978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when uname -m returns 'x84_64' Tried to do this without a patch--in princple this could be fixed by passing the correct --build flag to configure, but it was too tricky to do that on a conditional basis.
|
+1. BTW, how are you building on cygwin? By hand or using some sort of CI? (Can you do cygwin builds in AppVeyor?) |
|
Cygwin builds are possible on AppVeyor though I haven't tried it yet. Once I get everything working locally I could help set that up if you want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…when
uname -mreturns'x84_64'Tried to do this without a patch--in princple this could be fixed by passing the correct --build flag
to configure, but it was too tricky to do that on a conditional basis.
This could also be fixed by giving sqlite a newer
config.guessentirely but it's easy enough to add this one small patch.