11922 :: UdsChannelBuilder does not work with WiFi Proxy on Android. #12324
Conversation
| .getMethod("socketFactory", SocketFactory.class) | ||
| .invoke(builder, new UdsSocketFactory(path, namespace)); | ||
| return builder; | ||
| if (builder == null) { |
There was a problem hiding this comment.
Remove this check for builder == null. There is no need for this check.
There was a problem hiding this comment.
Thanks @kannanjgithub for the review. I've added a null check to resolve the following warnings and satisfy the code quality check:
Warning:(85, 22) Method invocation 'proxyDetector' may produce 'NullPointerException'
The warnings will be resolved with 'assert builder != null' or a 'null check'. Could you please confirm if it's okay for me to ignore these warnings and remove the null check?
There was a problem hiding this comment.
You can suppress the warnings. NPE will happen for reflected methods when the requested method name or class name is not available but that cannot happen here since we know they are definitely available.
There was a problem hiding this comment.
Thanks for the suggestions @kannanjgithub , I have addressed the review comments and please review it once You get some bandwidth.
shivaspeaks
added
the
kokoro:force-run
grpc-kokoro
removed
the
kokoro:force-run
| * @param path unix file system path to use for Unix Domain Socket. | ||
| * @param namespace the type of the namespace that the path belongs to. | ||
| */ | ||
| @SuppressWarnings("ConstantConditions") |
There was a problem hiding this comment.
@ejona86 , This code was added to fix the NullPointerException warning that was appearing for proxyDetector.
Warning:(85, 22) Method invocation 'proxyDetector' may produce 'NullPointerException'
There was a problem hiding this comment.
The IDE was saying that, or our build? We don't have any nullness checks in our build. We don't tend to put IDE suppressions in the code.
Fixes : #11922