Update common_engine_methods_and_macros.rst #11339
Open
+0
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the .cstr() function on String appears to be removed. code does not compile when used in a C++ Module. in 4.5
Ivorforce
approved these changes
Oct 5, 2025
Calinou
reviewed
Oct 6, 2025
Comment on lines
-57
to
-60
| // Converts the resulting String into a `const char *`. | ||
| // You may need to do this if passing the result as an argument | ||
| // to a method that expects a `const char *` instead of a String. | ||
| vformat("My name is %s.", "Godette").c_str(); |
There was a problem hiding this comment.
I would readd it in its current forrm, i.e. replace .c_str() with .utf8().get_data().
I know that personally, I was looking for this all the time when I started contributing to Godot 🙂 It's the same when I contribute to other open source projects in C++.
There was a problem hiding this comment.
honestly I agree, since it would help with interoperability with older apis if the user so wishes to use them,
I'll go run a check if it works properly and probably push the change if the .utf8().get_data() thing works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the .cstr() function on String appears to be removed. code does not compile when used in a C++ Module. in 4.5