Add support for literals in compact patterns #952
Merged
+15
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The committers listed above are authorized under a signed CLA. |
|
Released 1.7.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
The code was not accounting for the possibility of string literals in compact patterns (example).
This was causing issues with the compact rendering of numbers in some languages.
What approach did you choose and why?
Copied the same regex for detecting literals in the
stringToPartsfunction, and applied it tocompactPattern.What should reviewers focus on?
That the regex makes sense.
It's safe to add the
'to the negated character class, since a'is either the start of a string literal or should be escaped with a second', both of which are covered by the first case in the alternation.The impact of these changes
Fixes #917
Fixes #946