Block creating mesh shader pipelines when the feature is not available #8298
+96
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disallow creation of mesh shader pipelines when the feature is not available. This is tested by compiling a non-mesh
ShaderModule
, specifying it in the mesh shader position of the pipeline descriptor, and callingcreate_mesh_pipeline
.I've also changed the rest of the mesh shader tests so they're reported as backend skips rather than vacuous passes when they aren't supported.
Testing
Constitutes 99% of the PR.
Squash or Rebase? Squash
Checklist
cargo fmt
.taplo format
.cargo clippy --tests
. If applicable, add:--target wasm32-unknown-unknown
cargo xtask test
to run tests.CHANGELOG.md
entry.