Skip to content

Conversation

maskshell
Copy link

@maskshell maskshell commented Sep 2, 2025

Summary

Replace uv installation path from root path /root/.local/bin
to public path /usr/local/bin since the user app cannot access
the root's home directory.

Type of Change

  • [*] Bug fix

Important

Fix uv installation path in Dockerfile to ensure app user access, with minor formatting changes elsewhere.

  • Dockerfile Changes:
    • Change uv installation path from /root/.local/bin to /usr/local/bin in Dockerfile to ensure app user access.
    • Modify RUN command to use curl for direct installation of uv to the new path.
  • Miscellaneous:
    • Minor formatting changes in driver.py, falkordb_driver.py, helpers.py, and search_utils.py (e.g., whitespace adjustments).

This description was created by Ellipsis for a0b0124. You can customize this summary. It will automatically update as commits are pushed.

@danielchalef
Copy link
Member

danielchalef commented Sep 2, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@maskshell
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to a0b0124 in 52 seconds. Click for details.
  • Reviewed 89 lines of code in 5 files
  • Skipped 0 files when reviewing.
  • Skipped posting 5 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. graphiti_core/driver/driver.py:49
  • Draft comment:
    Minor formatting change: using a multiline definition for fulltext_syntax improves readability.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 80% None
2. graphiti_core/driver/falkordb_driver.py:100
  • Draft comment:
    Extraneous blank line removal after setting fulltext_syntax cleans up the code.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 80% None
3. graphiti_core/helpers.py:51
  • Draft comment:
    Inserted blank lines between functions enhance readability and logical separation.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 80% None
4. graphiti_core/search/search_utils.py:64
  • Draft comment:
    Reformatted list comprehension for group_ids_filter_list enhances code clarity.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 80% None
5. mcp_server/Dockerfile:13
  • Draft comment:
    Using curl with the UV_INSTALL_DIR environment variable installs uv in /usr/local/bin, ensuring the non-root 'app' user can access it. Also, updating the cache mount to /app/.cache/uv is appropriate.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 80% This comment is purely informative and does not provide any actionable feedback or suggestions for improvement. It simply describes what the code is doing without offering any critique or suggestion for change.

Workflow ID: wflow_8NVJqJ5TB8ZqjUG7

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

danielchalef added a commit that referenced this pull request Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants