Skip to content

Conversation

liangyuanpeng
Copy link

@liangyuanpeng liangyuanpeng commented Aug 20, 2025

I'm using mcp with custom embedder module and since there was no documentation, it took me some time. I think adding this instruction would be very useful.

Summary

Brief description of the changes in this PR.

Type of Change

  • Bug fix
  • New feature
  • Performance improvement
  • Documentation/Tests

Objective

For new features and performance improvements: Clearly describe the objective and rationale for this change.

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • All existing tests pass

Breaking Changes

  • This PR contains breaking changes

If this is a breaking change, describe:

  • What functionality is affected
  • Migration path for existing users

Checklist

  • Code follows project style guidelines (make lint passes)
  • Self-review completed
  • Documentation updated where necessary
  • No secrets or sensitive information committed

Related Issues

Closes #[issue number]


Important

Add documentation for configuring custom embedder models in MCP server by introducing EMBEDDER_MODEL_NAME in README.md and .env.example.

  • Documentation:
    • Adds EMBEDDER_MODEL_NAME to README.md and .env.example for configuring custom embedder models.
    • Provides instructions for setting EMBEDDER_MODEL_NAME for embedding operations in README.md.

This description was created by Ellipsis for 6530341. You can customize this summary. It will automatically update as commits are pushed.

Signed-off-by: Lan <gcslyp@gmail.com>
@danielchalef
Copy link
Member

danielchalef commented Aug 20, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 6530341 in 42 seconds. Click for details.
  • Reviewed 26 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. mcp_server/.env.example:14
  • Draft comment:
    Good addition for embedder configuration. Consider adding a note that this variable is commented out by default and must be uncommented to take effect.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 80% None
2. mcp_server/README.md:94
  • Draft comment:
    Nice documentation update. For clarity, consider adding a brief example of how to set EMBEDDER_MODEL_NAME in a .env file.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 80% None

Workflow ID: wflow_OUlvfqBzU9xgX23A

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@liangyuanpeng
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

danielchalef added a commit that referenced this pull request Aug 20, 2025
danielchalef added a commit that referenced this pull request Aug 25, 2025
AIXerum pushed a commit to AIXerum/graphiti that referenced this pull request Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants