Skip to content

Conversation

lobsterkatie
Copy link
Member

@lobsterkatie lobsterkatie commented Oct 9, 2025

This changes the format of the grouping info API response, so that instead of the full serialized grouping config being included in every variant, only the grouping config id included at the top level of the JSON, and the variants in turn are included under a new variants key. In other words, it changes from a response that looks like this:

{
  app_exception_stacktrace: {
    ...,
    config: {
      id: "newstyle:whatever",  // the only part of `config` we actually care about
      ...
    }
  },
  system_exception_stacktrace:  {
    ...,
    config: {
      id: "newstyle:whatever",  // we don't need this twice
      ...
    }
  }
}

to one which looks like this:

{
  grouping_config: "newstyle:whatever",
  variants: {
    app_exception_stacktrace: {...},
    system_exception_stacktrace: {...}
  }
}

This not only removes redundancy (along with a bunch of information about the config we don't need), it also sets us up to be able to send other grouping-info-wide information in the response.

Note: Before this can be merged, the front end needs to be adjusted to work with both the old and new formats. Once that's deployed, and this is merged and deployed, we can remove old-format handling from the front end.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 9, 2025
@lobsterkatie lobsterkatie force-pushed the kmclb-move-grouping-config-to-top-level-of-grouping-info branch from 57568f5 to f72b48e Compare October 9, 2025 19:20
@lobsterkatie lobsterkatie force-pushed the kmclb-move-grouping-config-to-top-level-of-grouping-info branch from f72b48e to 8046242 Compare October 9, 2025 20:48
@lobsterkatie lobsterkatie marked this pull request as ready for review October 9, 2025 22:58
@lobsterkatie lobsterkatie requested review from a team as code owners October 9, 2025 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant