ref(settings): Remove usage of deprecatedRouteProps from TeamDetails settings view & its children
#101134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ew and its children
github-actions
bot
added
the
Scope: Frontend
shashjar
commented
Oct 7, 2025
| deprecatedRouteProps: true, | ||
| }, | ||
| { | ||
| path: 'notifications/', |
There was a problem hiding this comment.
TeamNotificationSettings makes its own API request to fetch the team - I believe this is unnecessary and it can be folded into the same pattern as the other children with useOutletContext. @scttcper mind confirming?
shashjar
commented
Oct 7, 2025
| </TabsContainer> | ||
|
|
||
| {isValidElement(children) ? cloneElement<any>(children, {team}) : null} | ||
| <Outlet context={{team} satisfies TeamDetailsOutletContext} /> |
There was a problem hiding this comment.
Is this the pattern we want? i.e. define a type for the outlet context and then assert that type on the object given to Outlet as context. Is there a better way to enforce this type?
shashjar
commented
Oct 7, 2025
| const org = OrganizationFixture({access: [], openMembership: true}); | ||
| render(<TeamMembers team={team} />, { | ||
| render(<TeamMembers />, { | ||
| outletContext: {team}, |
There was a problem hiding this comment.
Is there a way we can enforce the types match when outletContext is provided to render? (other than putting satisfies everywhere)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates usage of
deprecatedRoutePropsforTeamDetails(sentry/views/settings/organizationTeams/teamDetails) and its children:TeamMembers(sentry/views/settings/organizationTeams/teamMembers)TeamProjects(sentry/views/settings/organizationTeams/teamProjects)TeamSettings(sentry/views/settings/organizationTeams/teamSettings)https://www.notion.so/sentry/Frontend-TSC-Project-Remove-all-uses-of-deprecatedRouteProps-true-26a8b10e4b5d8015a6a2dd14f9d41dd7