chore(explore): Migrate traces to use query params for sorts #101127
Conversation
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| }); | ||
|
|
||
| act(() => setSortBys([{field: 'max(span.duration)', kind: 'desc'}])); | ||
| act(() => setAggregateSortBys([{field: 'max(span.duration)', kind: 'desc'}])); |
There was a problem hiding this comment.
Bug: Aggregate Tests Use Incorrect Sort Method
Several aggregate mode tests incorrectly use setSortBys to update sort parameters. After recent changes, setSortBys now controls sample sorts, so these tests should instead call setAggregateSortBys to update the correct state.
Additional Locations (3)
| : writableQueryParams.sortBys?.map( | ||
| sort => `${sort.kind === 'desc' ? '-' : ''}${sort.field}` | ||
| ) | ||
| ); |
There was a problem hiding this comment.
Bug: Query Parameters Handle Nulls and Undefines Differently
The sortBys and aggregateSortBys query parameter updates might handle null and undefined inputs inconsistently. While null inputs explicitly result in null, undefined inputs would pass through optional chaining (?.map()) and yield undefined for updateNullableLocation, potentially causing unexpected behavior.
Additional Locations (1)
| const [sorts, setSorts] = | ||
| mode === Mode.SAMPLES | ||
| ? [sampleSortBys, setSampleSortBys] | ||
| : [aggregateSortBys, setAggregateSortBys]; |
There was a problem hiding this comment.
Bug: Stale State in Conditional Variable Assignment
The conditional assignment of sorts and setSorts based on mode means these variables don't update when mode changes. This can lead to incorrect sorting behavior or stale state being used in the component.
Zylphrex
deleted the
txiao/chore/migrate-explore-traces-to-use-query-params-for-sorts
branch
2 participants
No description provided.