-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat(sub v3): New Usage Overview #101122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sub v3): New Usage Overview #101122
Conversation
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but had a question
|
||
const daysLeft = -1 * getDaysSinceDate(trial.endDate ?? ''); | ||
const tagType = type ?? (daysLeft <= 7 ? 'promotion' : 'highlight'); | ||
const tagType = type ?? (daysLeft <= 14 ? 'warning' : 'highlight'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will we ever have a highlight
tag type? since product trials are 14 days and we return above if it hasn't been started or ended already
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mb i accidentally changed this to 14 💀
> | ||
<Flex align="center" gap="sm"> | ||
<IconLightning size="xs" /> | ||
<Container>{t('Start 14 day free trial')}</Container> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they don't
This introduces the new table. A follow up PR will handle implementing the new flyouts.
with billing perms:
without billing perms: