Skip to content

Conversation

ArthurKnaus
Copy link
Member

@ArthurKnaus ArthurKnaus requested a review from a team October 7, 2025 20:26
@linear
Copy link

linear bot commented Oct 7, 2025

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 7, 2025
manager.add("organizations:more-fast-alerts", OrganizationFeature, FeatureHandlerStrategy.INTERNAL, api_expose=False)
manager.add("organizations:more-slow-alerts", OrganizationFeature, FeatureHandlerStrategy.INTERNAL, api_expose=False)
# Enable higher limit for workflows
manager.add("organizations:more-workflows", OrganizationFeature, FeatureHandlerStrategy.INTERNAL, api_expose=False)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential bug: Removing the organizations:mcp-insights feature flag registration will cause all frontend checks to fail, making the entire MCP feature set inaccessible.
  • Description: The removal of the organizations:mcp-insights feature flag registration will cause all frontend checks for this flag, such as in the hasMCPInsightsFeature function, to consistently return false. This will make the MCP module invisible in the Insights UI, block access to the main MCP overview page by rendering a NoAccess component, and prevent MCP-specific details from appearing in trace views. The cumulative effect is that the entire MCP feature set will become inaccessible to all users, which is contrary to the presumed intent of graduating the feature.

  • Suggested fix: To correctly graduate the feature, all frontend code that checks for the mcp-insights flag should be updated. This includes removing the checks from components like McpInsightsFeature, functions like hasMCPInsightsFeature, and dependency maps like MODULE_FEATURE_VISIBLE_MAP. The code should be modified to make MCP features unconditionally available before the flag registration is removed.
    severity: 0.85, confidence: 0.95

Did we get this right? 👍 / 👎 to inform future reviews.

@ArthurKnaus ArthurKnaus merged commit 816ba79 into master Oct 8, 2025
66 checks passed
@ArthurKnaus ArthurKnaus deleted the aknaus/ref/agents-insights/remove-feature-flag-registration branch October 8, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants