fix(tests): Replace direct Model.objects.create with factory method #100929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace DetectorGroup.objects.create() with create_detector_group() factory method in test_organization_open_periods.py to comply with Sentry testing standards. The test was violating the mandatory Python testing rule that prohibits direct Model.objects.create() calls. This change: - Uses the proper factory method from sentry.testutils.fixtures.Fixtures - Maintains identical test behavior and coverage - Follows Sentry's testing best practices - Ensures proper test setup logic is applied Files changed: - tests/sentry/workflow_engine/endpoints/test_organization_open_periods.py Testing: - All existing tests pass with no modifications to test logic - No linter errors introduced
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace DetectorGroup.objects.create() with create_detector_group() factory method in test_organization_open_periods.py to comply with Sentry testing standards.
The test was violating the mandatory Python testing rule that prohibits direct Model.objects.create() calls. This change:
Files changed:
Testing:
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.