Skip to content

Conversation

crashbandicootfm
Copy link
Contributor

Pull Request Type

What kind of change does this PR introduce?

Dark theme was updated to another color scheme. If you have any feedback on this, please let me know and I will make the necessary changes promptly. Thank you

Issue Number: #696

Copy link

vercel bot commented Oct 16, 2025

@crashbandicootfm is attempting to deploy a commit to the Niko Hoffrén's Team Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Oct 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
fork-commit-merge-web Ready Ready Preview Comment Oct 17, 2025 5:55am

Copy link
Member

@nikohoffren nikohoffren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good!

There's a small bug in the faq.tsx page, where the active tab should change to bright blue, but it changes to same color as the background, so it's a bit hard to see. Only the All-tab changes to blue, so it's the only one visible. Also, when changing to light mode it is even more apparent, because the link completely disappears with the text when active.

But i think that's just a minor flaw, i can fix that myself later on, so everything is good to be merged.

@nikohoffren nikohoffren merged commit 82239b9 into fork-commit-merge:main Oct 17, 2025
5 checks passed
@nikohoffren
Copy link
Member

Pull request merged

This is an automated message from Fork, Commit, Merge - web [BOT].

Thank you for your contribution! Your pull request has been merged and your name has been added to the List of Contributors in README.md.
Please leave a star if you enjoyed working on this project.

What's next?

If you're looking for more ways to contribute, I invite you to check out my other projects here.

@nikohoffren
Copy link
Member

Changes look good!

There's a small bug in the faq.tsx page, where the active tab should change to bright blue, but it changes to same color as the background, so it's a bit hard to see. Only the All-tab changes to blue, so it's the only one visible. Also, when changing to light mode it is even more apparent, because the link completely disappears with the text when active.

But i think that's just a minor flaw, i can fix that myself later on, so everything is good to be merged.

I fixed it, there was just still bg purple used in the activeCategory, but that's now changed to bg-modern-blue:

{categories.map(category => (
              <button
                key={category}
                onClick={() => setActiveCategory(category)}
                className={`rounded-full px-6 py-2 text-sm font-medium transition-all duration-200 ${
                  activeCategory === category
                    ? 'bg-modern-blue text-white'
                    : 'bg-gray-100 text-gray-600 hover:bg-gray-200'
                }`}
              >
                {category}
              </button>
            ))}

@crashbandicootfm
Copy link
Contributor Author

Thank you for accepting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants