-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[mustache_template] Emoji support #10110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds emoji support to the mustache template parser by correctly handling runes instead of UTF-16 code units. The changes in scanner.dart
correctly use runes for parsing, and new tests have been added to verify emoji handling.
I've identified a performance issue with the current approach in scanner.dart
and suggested a more memory-efficient implementation. Additionally, I found a small error in one of the new tests regarding character offsets.
As a side note for future improvements, while parsing is fixed, the error reporting in TemplateException
might still have issues with emojis, as it appears to use code unit-based offsets. This could be a good follow-up to ensure full emoji support across the package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this and adding the additional tests!
Support emojis in templates. The code was relying on String.length, when doing substring, which could be wrong when emojis are used.
Fixes flutter/flutter#176180
Pre-Review Checklist
[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assist
bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3