-
Notifications
You must be signed in to change notification settings - Fork 330
✨ Implement PubspecLineMarkerProvider for pubspec.yaml features
#8551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for looking into this! I'm realizing that for this size feature, we probably need to discuss more the functionality you're adding here. As a starting point:
|
|
Great, thanks for the info, it helps me understand a lot more. We'll discuss this feature and approach next week; I recommend waiting until then to continue work on it. Hopefully we can give you clear guidance after convening! |
|
@helin24 How is the internal meeting going? Do we have further ideas about this change? |
|
@AlexV525 sorry about the delay - we have this on the agenda to discuss, but due to a variety of fairly random factors we haven't gotten to it yet! I promise you will hear from us though. |
|
@AlexV525 we finally discussed this; here are our thoughts:
|
|
I haven't had a chance to look at the specific features, but we do already have support for |
We do already have some of this (opening on pub.dev/github) in the server in LSP's Document Links: I don't know if there's anything missing compared to what's here, but if so I also agree it'd be best to add it to the server and then reuse that data here (it avoids multiple implementations and keeps them consistent across editors). |
|
Thanks for the info! @AlexV525 for the moment we'll close this PR on this repo. When the Dart plugin is open source, we can add this PR as a first step. Following that, we can improve by integrating the analysis server info. If we have a chance to look investigate the analysis server output (or you want to look into it) then we may be able to use that in the Dart plugin as part of the initial change instead of this PR. |
|
Good to know all these details. Thanks
IIRC, isn't the Dart plugin open-source already? https://github.com/JetBrains/intellij-plugins/tree/master/Dart |





Resolves #8511
The PR implements a plugin that provides YAML-related features specifically targeting
pubspec.yaml. It includes dependency references currently. Future implementation can be based on this provider.Contribution guidelines:
dart format.