Skip to content

RF Autograd Patch Antenna Optimization with PEC Boxes #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

RF Autograd Patch Antenna Optimization with PEC Boxes #376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c8de1b4
box pec optimization notebook
May 30, 2025
d41eb57
formatted
May 30, 2025
ea6bcab
update notebook with all cells run
Jun 2, 2025
c87642d
current autograd notebook
Jul 3, 2025
27fd345
add images
Jul 3, 2025
d50199b
newest patch
Aug 27, 2025
00c1e57
rf autograd pec patch antenna optimization notebook
Sep 12, 2025
af13490
review comments round 1
Sep 18, 2025
5057f7a
add first notebook split
Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2,702 changes: 2,702 additions & 0 deletions RFAutograd1RectangularPatchAntenna.ipynb
View file
Open in desktop
Copy link
Contributor

@yaugenst-flex yaugenst-flex Sep 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @groberts-flex, heroic effort! I agree it looks great overall, so I'll also mostly resort to nit-picking:

  1. The introduction is a ~20 line paragraph. Splitting this into a couple of shorter paragraphs would make this a lot easier to digest.

  2. The leading image is cut off for me on the right (see screenshot, and notice the scroll bar too):

    Image

    Let's try to make these illustrations fit?

  3. In cell [2], sub_z is assigned twice to different values.

  4. The first optimization loop prints a lot of information at every iteration. I guess this is a matter of taste, but I find it quite noisy and it makes it a bit harder to scroll through the notebook. I feel like trimming this down would help. For example, gradients, updates, and params are somewhat redundant/interchangeable no? And/or reducing the print cadence (also for the second optimization). Basically, the longer these logs are, the more these will eclipse the actual figures and overall flow of the notebook.

  5. Also not sure if this is possible, but can we suppress the validation logs? They're pretty distracting in that loop.

  6. I noticed a couple of typos ("optimziation", "inital"), but i think these should be caught by the spellcheck. On that note, the notebook needs a ruff pass.

Large diffs are not rendered by default.

Loading
Loading