Skip to content

feature/multi-source-spelling #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feature/multi-source-spelling #70

wants to merge 4 commits into from

Conversation

fivetran-joemarkiewicz
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz commented Sep 8, 2025 •
edited
Loading

PR Overview

Package version introduced in this PR:

  • v2.0.1 (after pre-release is verified and mechanism created for variable)

This PR addresses the following Issue/Feature(s):

  • Internal

Summary of changes:

  • Added the salesforce_naming_convention variable to account for different naming conventions of Salesforce source tables.

Submission Checklist

  • Alignment meeting with the reviewer (if needed)
    • Timeline and validation requirements discussed
  • Provide validation details:
    • See internal ticket for testing confirmation.
    • Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
    • Testing Instructions: Confirm the change addresses the issue(s)
    • Focus Areas: Complex logic or queries that need extra attention
  • Merge any relevant open PRs into this PR

Changelog

  • Draft changelog for PR
  • Final changelog for release review

@fivetran-joemarkiewicz fivetran-joemarkiewicz self-assigned this Sep 8, 2025
@fivetran-joemarkiewicz fivetran-joemarkiewicz added the docs:ready Triggers the docs generator workflow. label Sep 8, 2025
@fivetran-joemarkiewicz fivetran-joemarkiewicz marked this pull request as ready for review September 8, 2025 20:35
@fivetran-joemarkiewicz fivetran-joemarkiewicz added the pre-release Triggers the auto-releaser workflow. label Sep 8, 2025
fivetran-catfritz
fivetran-catfritz approved these changes Sep 8, 2025
View reviewed changes
Copy link
Contributor

@fivetran-catfritz fivetran-catfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny change, but otherwise lgtm!

@fivetran-joemarkiewicz @fivetran-catfritz
Update README.md
64f6a23 
Co-authored-by: fivetran-catfritz <111930712+fivetran-catfritz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fivetran-catfritz fivetran-catfritz fivetran-catfritz approved these changes

Assignees

@fivetran-joemarkiewicz fivetran-joemarkiewicz

Labels
docs:ready Triggers the docs generator workflow. pre-release Triggers the auto-releaser workflow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fivetran-joemarkiewicz @fivetran-catfritz