feat(dc): Add executeQuery and executeMutation APIs to Data Connect #2979
Conversation
Note:The integration tests have a huge diff because I moved the existing tests under a new parent |
|
Forgot a few changes! Didn't know that you could close and re-open :P thanks Yuchen! |
|
wait - need to privatize the execute API, execution should come from operation refs (in a future PR) |
| user_upsert(data: { id: "fred_id", address: "32 Elm St.", name: "Fred" }) | ||
| } | ||
| mutation updateFredrickUserImpersonation @auth(level: USER) { | ||
| mutation updateFredrickUserImpersonation @auth(level: USER, insecureReason: "test") { |
There was a problem hiding this comment.
Note: These changes likely require a re-deploy on the CI project
There was a problem hiding this comment.
Yes, they deff do - I'll leave this comment open to make sure it gets re-deployed! Tagging @lahirumaramba
test/unit/data-connect/data-connect-api-client-internal.spec.ts
Outdated
Show resolved
Hide resolved
test/unit/data-connect/data-connect-api-client-internal.spec.ts
Outdated
Show resolved
Hide resolved
…s, bypassing auth policies
…ions, bypassing auth policies
…ion]Result to exported api
| { | ||
| "name": "firebase-admin", | ||
| "version": "13.4.0", | ||
| "version": "13.5.0", |
There was a problem hiding this comment.
The version should only be bumped in a release PR. You can revert this for now and we will change it when we are ready to cut the next release
| } | ||
|
|
||
| /** @internal */ | ||
| public executeQuery<Data, Variables>( |
There was a problem hiding this comment.
If we are not exporting these as part of the public API, would it make sense to removeexecuteQuery and executeMutation fromsrc/data-connect/data-connect.ts?
| } | ||
|
|
||
| // @public (undocumented) | ||
| export interface OperationResult<Data, Variables> { |
There was a problem hiding this comment.
Could you check why some of these new types are missing documentation, please?
lahirumaramba
changed the title
API Changes
executeQuery()andexecuteMutation()tosrc/data-connect/data-connect.ts. These allow users to call deployed operations with impersonated auth credentials.Testing
executeGraphql*APIsexecuteGraphql*APIs