Add grayscale, drop-shadow and saturate filter support on iOS #53873
+83
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
intergalacticspacehighway
changed the title
facebook-github-bot
added
the
Shared with Meta
intergalacticspacehighway
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR adds support for
grayscale,drop-shadowandsaturatefilter support on iOS as discussed here - react-native-community/discussions-and-proposals#927Changelog:
[IOS] [ADDED] - Add grayscale, drop-shadow and saturate CSS filters
Test Plan:
Test Filter screen in RNTester app. Checkout
grayscale,drop-shadowandsaturateexamples. Results are consistent on android and iOS.Aside
Will do one more PR to add remaining filters. Splitting into two to keep it easier to review.