Improve error handling and filename extraction robustness #161
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the library's robustness by improving error handling and fixing edge cases in two key areas:
Enhanced Size String Converter Error Handling
The
convert_size_string_to_bytes()
function previously crashed with unclear errors on malformed input:Improvements:
Robust HTTP Filename Extraction
The
download_file()
function used a simplistic regex pattern that failed on many real-world Content-Disposition headers:Benefits:
Minor Performance Optimization
Removed redundant
file.seek(0)
call inread_file_lines_count()
since files are already at position 0 when opened.Testing
All existing tests pass (153/155, with 2 environment-specific permission test failures). The improvements maintain complete backward compatibility while enhancing robustness for edge cases and real-world usage scenarios.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.