Skip to content

Conversation

chfast
Copy link
Member

@chfast chfast commented Sep 30, 2025

🗒️ Description

Add more tests cases for the p256verify precompile where the final computed point R is at infinity by passing Q = -G and u1 == u2.

Similar test cases exist in "wycheproof_extra".

🔗 Related Issues or PRs

#2194

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

Add more tests cases for the `p256verify` precompile where the final
computed point `R` is at infinity by passing `Q = -G` and `u1 == u2`.

Similar test cases exist in "wycheproof_extra".
Copy link
Contributor

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Passing on all ELs.

@spencer-tb spencer-tb added scope:tests Scope: Changes EL client test cases in `./tests` type:feat type: Feature fork:osaka Osaka hardfork labels Oct 1, 2025
@marioevz marioevz merged commit 7152202 into ethereum:main Oct 1, 2025
15 checks passed
@marioevz marioevz deleted the tests/p256_R0 branch October 1, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fork:osaka Osaka hardfork scope:tests Scope: Changes EL client test cases in `./tests` type:feat type: Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants