chore**s**(src): use --chain-id
in ProgramChainid
#2232
+6
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
If you run geth with
geth --dev --http -http.addr=localhost --http.port=8545
and then run
uv run execute remote -m blockchain_test --fork=frontier --rpc-endpoint=http://127.0.0.1:8545 --rpc-seed-key=b71c71a67e1177ad4e901695e1b4b9ee17ae16c6668d313eac2f96dbcda3f291 --tx-wait-timeout 60 -vv -s tests/frontier/scenarios/test_scenarios.py::test_scenarios -k "ChainId" -vv -s --chain-id=1337
you can see that the passed chain-id is used (if you print it).
But why does it only work with
ChainConfigDefaults.chain_id
and not withChainConfig.chain_id
? The PR that introduces this uses the latter without problems.Fixes #2095
🔗 Related Issues or PRs
N/A.
✅ Checklist
tox
checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
type(scope):
.mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_from
marker.