erts: Add guard BIF erlang:is_integer/3
#10276
Open
+532
−134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add guard BIF `erlang:is_integer/3`, following the design of the
original EEP-16, only changing the name from `is_between` to
`is_integer`. This BIF takes in 3 parameters, `Term`, `LowerBound`,
and `UpperBound`.
It returns `true` if `Term`, `LowerBound`, and `UpperBound` are
all integers, and `LowerBound =< Term =< UpperBound`; otherwise,
it returns false.
Failure: `badarg` if `LowerBound` or `UpperBound` does not evaluate to
an integer.
Example:
````
1> is_integer(2, 1, 10).
true
2> is_integer(11, 1, 10).
false
3> is_integer(1, 1.0, 10.0).
** exception error: bad argument
in function is_integer/3
called as is_integer(1,1.0,10.0)
````
Co-authored-by: Björn Gustavsson <bjorn@erlang.org>
Co-authored-by: John Högberg <john@erlang.org>
CT Test Results 7 files 635 suites 3h 13m 41s ⏱️ Results for commit a211a3a. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
lib/compiler/src/beam_validator.erl
Outdated
Comment on lines
2295
to
2303
| infer_types_1(#value{op={bif,is_integer},args=[Src, _, _]}, Val, Op, Vst) -> | ||
| %% Unknown bounds; we know it's an integer when 'true', but cannot draw | ||
| %% any conclusions when 'false'. | ||
| case Val of | ||
| {atom, Bool} when Op =:= eq_exact, Bool; Op =:= ne_exact, not Bool -> | ||
| update_type(fun meet/2, #t_integer{}, Src, Vst); | ||
| _ -> | ||
| Vst | ||
| end; |
There was a problem hiding this comment.
It's possible to narrow the range if just one of the bounds is a literal - I think we would do that with comparisons today, so converting them to is_integer guard would remove information from the compiler
lucioleKi
force-pushed
the
isabell/erts/is-integer-3/OTP-19809
branch
from
2fbafae to
a211a3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add guard BIF
erlang:is_integer/3, following the design of the original EEP-16, only changing the name fromis_betweentois_integer. This BIF takes in 3 parameters,Term,LowerBound, andUpperBound.It returns
trueifTerm,LowerBound, andUpperBoundare all integers, andLowerBound =< Term =< UpperBound; otherwise, it returns false.Failure:
badargifLowerBoundorUpperBounddoes not evaluate to an integer.Example:
We decide to not update and reuse the previous PR because the name of the BIF has changed.