Skip to content

SymbolPane: improve tooltips for C tags #1636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

SymbolPane: improve tooltips for C tags #1636

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e7201c
Override add_tooltip(s) for CtagsSymbolOutline
jeremypw Jul 17, 2025
d6bb7b6
Look on previous line for method type
jeremypw Jul 17, 2025
4ba573d
Merge branch 'master' into jeremypw/C-symbolpane/improve-tooltips
jeremypw Aug 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions src/SymbolPane/C/CtagsSymbolOutline.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,10 +275,42 @@ public class Scratch.Services.CtagsSymbolOutline : Scratch.Services.SymbolOutlin
destroy_root (root);
root = new_root;

add_tooltips (store.root);
return false;
});
}

protected override void add_tooltips (Code.Widgets.SourceList.ExpandableItem root) {
foreach (var parent in root.children) {
if (parent is Code.Widgets.SourceList.ExpandableItem) {
add_tooltip ((Code.Widgets.SourceList.ExpandableItem) parent);
}
}
}

private void add_tooltip (Code.Widgets.SourceList.ExpandableItem parent) {
if (parent is CtagsSymbol) {
var item = ((CtagsSymbol)parent);
var start = item.line;
var end = item.line;
// The type of a method is often on the previous line
if (item.symbol_type == SymbolType.METHOD) {
start = start > 0 ? start - 1 : start;
}

item.tooltip = Markup.escape_text ("%s".printf (
doc.get_slice (
start,
0,
end,
0
)
));
}

add_tooltips (parent);
}

private void destroy_root (Code.Widgets.SourceList.ExpandableItem to_destroy) {
var children = iterate_children (to_destroy);
to_destroy.clear ();
Expand Down